search

AdiAddons / AdiBags

WoW Addon — Adirelle's bag addon.
https://wowace.com/projects/adibags
GNU General Public License v3.0
156 stars 112 forks source link

wowup support #633

Closed HawkCorrigan closed 2 years ago

HawkCorrigan commented 2 years ago

How high is the chance that you would package the addon releases here on github in a way that is supported by wowup?

Otherwise, what is your stance to people forking your repo and doing so?

HawkCorrigan commented 2 years ago

The setup process for packaging should be relatively easy to my understanding with https://github.com/BigWigsMods/packager/wiki/GitHub-Actions-workflow.

SpareSimian commented 2 years ago

I'm using Ajour for updating addons and would love to see this. (The Overwolf updater took a long time to start and then to update my long list of addons. Ajour does both in less than a second. I don't mind the ads, just the huge delay in those two steps.)

Lightless9 commented 2 years ago

AdiBags is one of the best addons in WoW. PLEASE make it available in WowUp!

jec324 commented 2 years ago

How high is the chance that you would package the addon releases here on github in a way that is supported by wowup?

Otherwise, what is your stance to people forking your repo and doing so?

AdiBags uses the GNU GPL3 license and under section 5 it lists that having/using/sharing modified code is OK provided you properly and adequately list it as such. That would probably be fine. However, give them a bit of time and they might just do so as well. Course that was just a cursory scan and I could have missed something more detailed saying no, I assume tho they'll have it up on other distributions when able.

Cidan commented 2 years ago

Hey folks,

I just added a simple workflow for packaging. It's a WIP and not live yet. @Talyrius any thoughts around versioning here?

Lightless9 commented 2 years ago

Any updates for AdiBags being accessible by wowup on Github?

Talyrius commented 2 years ago

AdiBags doesn't receive nor require frequent updates, so lets not pretend the need for this is more urgent than it actually is. It'll happen when it happens, alright?

Lightless9 commented 2 years ago

AdiBags doesn't receive nor require frequent updates, so lets not pretend the need for this is more urgent than it actually is. It'll happen when it happens, alright?

Ok! That's good to know. AdiBags is one of my favorite addons. Good news that it doesn't break easily.

mewt666 commented 2 years ago

AdiBags doesn't receive nor require frequent updates, so lets not pretend the need for this is more urgent than it actually is. It'll happen when it happens, alright?

I think it's more that people are trying to resolve the broken links in wowup and thus hounding developers endlessly. We appreciate your work and look forward to being able to use this addon in wowup whenever you're done :)

Cidan commented 2 years ago

Can someone externally confirm the new release on Github works with wowup? The release process is now ready for retail only -- no TBC/WotLK/Classic support yet.

daegalus commented 2 years ago

Can someone externally confirm the new release on Github works with wowup? The release process is now ready for retail only -- no TBC/WotLK/Classic support yet.

I can confirm it works with WoWUp

It uses the AdiAddons org icon as it's icon. So if you ever want it to have a custom icon, I guess you can just set the icon of the org.

PXL_20220821_052648034.jpg

Cidan commented 2 years ago

Excellent! I too confirmed locally that it works. I'm closing this and moving all further work on this to #646 -- the next goal is to get a unified tag/release for all running versions of WoW.

Thanks everyone!

SpareSimian commented 2 years ago

This also works with Ajour. I'd had the addon installed from Curse until they cut off 3rd party updaters so it was showing as "Unknown" source. I just used the "Install from URL" button and entered the GitHub link and it updated to the new release! Thanks for doing this!