search

AdiAddons / AdiBags

WoW Addon — Adirelle's bag addon.
https://wowace.com/projects/adibags
GNU General Public License v3.0
156 stars 112 forks source link

[Feature]: ElvUI/Clean Skin #776

Closed LiamGBR closed 10 months ago

LiamGBR commented 1 year ago

Describe the feature

Would a skin option directly in the addon be a possibility? Been relying on https://www.curseforge.com/wow/addons/elvui-adibags for a long time but its rarely updated quick enough to the point where I could be missing features for a while. (author has logged in recently but last update 9.0.5) It also usually has strange behaviour after an update where it may not work correctly without a full reinstall.

Describe the implementation

Unsure of how much effort would be needed for this but nows probably the best time to ask about it. Implemented with maybe a toggle in the settings somewhere.

juntereiner commented 1 year ago

More recently, there is https://www.curseforge.com/wow/addons/elvui-adibags-wrath which works before prepatch. But I agree, if possible it will be much better to have this option here.

KatyPurry commented 1 year ago

I agree ! Unfortunately https://www.curseforge.com/wow/addons/elvui-adibags seems abandoned.

Beet4 commented 1 year ago

YES! Please :D built in skin from Elvui Adibags would be awesome

ryankhart commented 1 year ago

I agree ! Unfortunately https://www.curseforge.com/wow/addons/elvui-adibags seems abandoned.

Looks like someone forked the original ElvUI_Adibags addon and there is an alpha branch on this repository, but at this moment is completely untested, but you might get lucky with it. https://github.com/Bauxite/ElvUI_AdiBags/tree/df_alpha

LiamGBR commented 1 year ago

Author of ElvUI plugin WindTools has released https://www.curseforge.com/wow/addons/adibagselvuiskin which doesn't require replacing the actual AdiBags addon so will use that for now.

KatyPurry commented 1 year ago

Awesome, a bit afraid of the Readme :

because the hack of AdiBags is not a very easy thing for me, to avoid blocking the method currently using, I make the core code not easy to read. but you can also add some post function for applying more styling things with the apis. check api.lua if you needed.

ryankhart commented 1 year ago

because the hack of AdiBags is not a very easy thing for me, to avoid blocking the method currently using, I make the core code not easy to read. but you can also add some post function for applying more styling things with the apis. check api.lua if you needed.

Wut... Is there another possible interpretation of this than, "I don't want people to copy, make changes, and redistribute my code so I'm intentionally obfuscating it."? That's what it sounds like me after looking had the Core.lua file.

KatyPurry commented 1 year ago

because the hack of AdiBags is not a very easy thing for me, to avoid blocking the method currently using, I make the core code not easy to read. but you can also add some post function for applying more styling things with the apis. check api.lua if you needed.

Wut... Is there another possible interpretation of this than, "I don't want people to copy, make changes, and redistribute my code so I'm intentionally obfuscating it."? That's what it sounds like me after looking had the Core.lua file.

Unfortunately yes, I don’t understand why Adbibags devs here would patch her addon lol