AdiAddons / AdiBags

WoW Addon — Adirelle's bag addon.
https://wowace.com/projects/adibags
GNU General Public License v3.0
157 stars 111 forks source link

Strange filter issue #930

Closed N6REJ closed 1 year ago

N6REJ commented 1 year ago

Addon Version

1.10.7

World of Warcraft Version

Retail

Describe the bug

There is a strange filtering issue where its creating 2 filters named "Enchanting" and another called "Elemental" There is already a pre-existing filter named "Enchanting" and "Elemental" so I don't understand why its not being reused. I searched the entire addon folder and neither item shows up.

image

Steps to reproduce

have dragon shard of knowledge in bank.

Verification

Talyrius commented 1 year ago

In the tooltip, look at the AH categories under "item information." You'll find that they differ and this is why they're kept separate.

N6REJ commented 1 year ago

@Cidan please reopen this, I don't think your answer is quite correct. Using the item shown there is no "ah category" since It can't be sold in the AH and even if it could why the duplicate filter names? There should ever only be ONE filter by name xyz. Why doesn't the ID &/OR name show up in adibags code?

Nor are they elements or enchants

Cidan commented 1 year ago

Hi there.

AdiBags does not maintain a list of items and categories, which is why you can't find it in the code. For each item, we call the WoW API and get its auction house category, which is how we filter items. Even items that can not be sold on the auction house have an item category for the auction house. We have known for at least a decade or so that Blizzard sometimes does put items in the wrong category.

Can you do me a favor, and show me a screenshot without the popup that shows both categories, then show me the extended popup information for each item? That should be three screenshots total: one for the bag, and one for each item.

N6REJ commented 1 year ago

Hi and ty for responding. I've only been playing wow a couple of years so there's ton's I don't know. I already added the one I showed above to one of my categories https://github.com/N6REJ/AdiBags_Bears_Ultimate/blob/3d2819156d5d2be3f813d8069f135bd8ebd4c3fc/DF-db.lua#L585-L603

per @Talyrius I looked at the item tooltip and discovered one of these is for legion the other for draenor. I don't know how much that has to do with it.

WoWScrnShot_020923_054504 WoWScrnShot_020923_054502 WoWScrnShot_020923_054443

My addon for enchanting is https://github.com/N6REJ/Adibags_Bears_Enchanting. Elemental items are used by so many classes I put them in a "DF-Global" file that is shared by all my adibag addons. I'm not going to pretend my code might not have errors. I've done my best to check for pre-existing filters and such.

Thanks for taking the time.

Talyrius commented 1 year ago

To see how classifications are obtained, please see GetItemInfo.

For example, using the items you've referenced above:

/run local _, itemLink, _, _, _, itemType, itemSubType = GetItemInfo(191784); print(format("%s:\nitemType = %q\nitemSubType = %q", itemLink, itemType, itemSubType)) -- Dragon Shard of Knowledge
/run local _, itemLink, _, _, _, itemType, itemSubType = GetItemInfo(124124); print(format("%s:\nitemType = %q\nitemSubType = %q", itemLink, itemType, itemSubType)) -- Blood of Sargeras
/run local _, itemLink, _, _, _, itemType, itemSubType = GetItemInfo(190326); print(format("%s:\nitemType = %q\nitemSubType = %q", itemLink, itemType, itemSubType)) -- Rousing Air
/run local _, itemLink, _, _, _, itemType, itemSubType = GetItemInfo(109693); print(format("%s:\nitemType = %q\nitemSubType = %q", itemLink, itemType, itemSubType)) -- Draenic Dust
[Dragon Shard of Knowledge]:
  itemType = "Tradeskill"
  itemSubType = "Elemental"
[Blood of Sargeras]:
  itemType = "Tradeskill"
  itemSubType = "Elemental"
[Rousing Air]:
  itemType = "Tradeskill"
  itemSubType = "Elemental"
[Draenic Dust]:
  itemType = "Tradeskill"
  itemSubType = "Enchanting"

Yes, sometimes Blizzard miscategorizes or subcategorizes items with the same name under separate categories. However, that doesn't appear to be what's at play here.

It would have been helpful context to add that you were using custom filters in addition to those toggleable from the "item category" options. AdiBags places these items into sections named "itemType#itemSubType" or, in the case of the above examples, "Tradeskill#Elemental" and "Tradeskill#Enchanting".