AdiihYT / BuildFFA

Implements a BuildFFA/KnockbackFFA gamemode.
0 stars 0 forks source link

fix the plugin as soon as possibble #1

Open FundyHD opened 1 year ago

FundyHD commented 1 year ago

So. The problem starting when the server boots up. the server has a plugin called "buildffa" sounds gay to be honest. anyways after setting up the arenas correctly (its correct cause Adi himself made the arena) sometimes when players die in the void they get spammed with money and death messages over 100-200 times

AdiihYT commented 1 year ago

Welcome @FundyHD!

I am especially glad that you opened an issue on the project and thank you for contributing to the development of the plugin! Unfortunately, I did not manage to reproduce the problem in the first 5 attempts, so I would like to ask for precise details of what conditions must be met for the problem to occur.

The plugin basically checks if the player's Y-coordinate has exceeded the value specified in the configuration in a negative direction and if so, it kills the player and takes away their equipment. The following code snippet belongs to this function: https://github.com/MineZoneHU/BuildFFA/blob/master/src/main/java/eu/adiih/buildffa/listeners/GameplayListeners.java#L87

@EventHandler
    public void onPlayerMove(final PlayerMoveEvent event) {
        Player player = event.getPlayer();
        if(plugin.getGameNode() == null) return;
        if(event.getTo().getY() <= plugin.getGameNode().getCurrentMap().getVoidKillY()) {
            player.setHealth(0D);
        }
    }

Please write down more details to reproduce the problem or maybe suggestions to solve it, thank you in advance, have an amazing day!

FundyHD commented 1 year ago

Welcome @FundyHD!

I am especially glad that you opened an issue on the project and thank you for contributing to the development of the plugin! Unfortunately, I did not manage to reproduce the problem in the first 5 attempts, so I would like to ask for precise details of what conditions must be met for the problem to occur.

The plugin basically checks if the player's Y-coordinate has exceeded the value specified in the configuration in a negative direction and if so, it kills the player and takes away their equipment. The following code snippet belongs to this function: https://github.com/MineZoneHU/BuildFFA/blob/master/src/main/java/eu/adiih/buildffa/listeners/GameplayListeners.java#L87

@EventHandler
    public void onPlayerMove(final PlayerMoveEvent event) {
        Player player = event.getPlayer();
        if(plugin.getGameNode() == null) return;
        if(event.getTo().getY() <= plugin.getGameNode().getCurrentMap().getVoidKillY()) {
            player.setHealth(0D);
        }
    }

Please write down more details to reproduce the problem or maybe suggestions to solve it, thank you in advance, have an amazing day!

Thank you for the kind words @AdiihYT. i really can't describe it any better. The perfect solution would be for you to try and reproduce the bug by yourself.

thank you for your kind help!