search

Adittya-Gupta / Ethos

2 stars 12 forks source link

added footer #20

Open Devesh-Daku opened 9 months ago

Devesh-Daku commented 9 months ago

resolved issue #18 i have added a footer details can be modified accordingly by you styling and addition of footer is completed by my side

Adittya-Gupta commented 9 months ago

The code looks good.....Can you please share some picutre/video showing the implementation?

Adittya-Gupta commented 9 months ago

Also please add the contribution.md file

Devesh-Daku commented 9 months ago

sure here it is

https://github.com/Adittya-Gupta/Ethos/assets/121988601/680b21d0-5a15-460f-87fa-41e30c688e03 ![Uploading ethos.png…]()

Devesh-Daku commented 9 months ago

![Uploading ethos.png…]()

Devesh-Daku commented 9 months ago

Please check discord , i am getting some error while uploading

Devesh-Daku commented 9 months ago

Changed name , changed link , changed color please have a look on discord

Adittya-Gupta commented 9 months ago

In the changes that you have made now, I can see that you have hardcoded the color of the footer. You should not do that because if I change the theme from dark to light it will not look good