search

AdityaGupta1 / minecraft-modding-book

The repository for the Minecraft Modding book by O-Reilly.
58 stars 16 forks source link

Forge 1.8.9 and 1.9 beta #21

Open ldath opened 8 years ago

ldath commented 8 years ago

If you are interested I have 2 branches in my fork for Forge 1.8.9 and 1.9 beta

AdityaGupta1 commented 8 years ago

Thanks for doing this, this is actually exactly what I was going to work on over spring break.

Can you please send a pull request to make a new branch for the 1.9 mods?

AdityaGupta1 commented 8 years ago

Also, I fixed the two "TODO"s (commented on their code) on your latest commit (https://github.com/ldath/minecraft-modding-book/commit/f82a559d8bb0a3f4171e2a32daf109d37e031673) to the Forge 1.9 branch of your fork. They worked when I tested them, so they should work as replacements for the 1.8 code.

AlexFlynn commented 8 years ago

I’m not exactly sure what you need. Do you want me to make a new branch from your original and rename it 1.9 mods?

From: AdityaGupta1 [mailto:notifications@github.com] Sent: Wednesday, March 30, 2016 5:36 PM To: AdityaGupta1/minecraft-modding-book minecraft-modding-book@noreply.github.com Subject: Re: [AdityaGupta1/minecraft-modding-book] Forge 1.8.9 and 1.9 beta (#21)

Thanks for doing this, this is actually exactly what I was going to work on over spring break.

Can you please send a pull request to make a new branch for the 1.9 mods?

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/AdityaGupta1/minecraft-modding-book/issues/21#issuecomment-203644883 https://github.com/notifications/beacon/AKbMtCpXF9lsUs9Sd9CNdxBqaKsoTBtHks5pyuzIgaJpZM4H7sUx.gif

AdityaGupta1 commented 8 years ago

I was requesting a pull request from @ldath, not you. However, if you have a 1.9 version of the mods, you could also send a pull request. I would like the request to put the 1.9 mods in a separate branch.

ldath commented 8 years ago

Hi,

No problem, please create branch forge-1.9 in the repository an push it to the github than I'll create pull request not to master but to this branch.

Kind regards Arkadiusz Tułodzieci

2016-03-30 23:36 GMT+02:00 AdityaGupta1 notifications@github.com:

Thanks for doing this, this is actually exactly what I was going to work on over spring break.

Can you please send a pull request to make a new branch for the 1.9 mods?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/AdityaGupta1/minecraft-modding-book/issues/21#issuecomment-203644883

AdityaGupta1 commented 8 years ago

I added a forge-1.9 branch. Can you please send a pull request to that branch?