search

AdityaHegde / TwitterClient

0 stars 0 forks source link

[Android Bootcamp] Project 5: Twitter with Fragments Project - Ready for Review #2

Open AdityaHegde opened 9 years ago

AdityaHegde commented 9 years ago

App is complete and ready for review.

I didn't have to use different fragments for home and mentions timeline. But i did have a list of tweets fragment which encapsulates pull to refresh and infinite scroll. Did i do something wrong?! It does feel like a hacky solution.

@nidhi1608 @thecodepath

nidhi1608 commented 9 years ago

:+1: Project looks good. You solution seems fine as well. Unless your fragments are performing various tasks in the context of the application, its completely fine to reuse the same fragment.

I have provided a detailed Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for pinterest, yardsale or flickr using the same patterns.