search

AdityaNG / kan-gpt

The PyTorch implementation of Generative Pre-trained Transformers (GPTs) using Kolmogorov-Arnold Networks (KANs) for language modeling
https://adityang.github.io/kan-gpt/
MIT License
703 stars 54 forks source link

fix: `NotImplementedError` in download_dataset #22

Closed yumemio closed 4 months ago

yumemio commented 5 months ago

Summary :memo:

Fixes the issue of download_dataset raising NotImplementedError even if a correct dataset name is specified.

Details

  1. pip install kan_gpt
  2. Download a dataset: 
    $ python3 -m kan_gpt.download_dataset --dataset tinyshakespeare
  3. Old behavior: raises NotImplementedError after downloading the dataset
  4. New behavior: the script exits without throwing the error

Checks

Thanks for reviewing!