AdityaSavara
commented
2 years ago - [x] createMixedReferencePatterns should be set to false if no standard or existing (external) file is provided.
- [ ] exporting improvements as noted here: https://github.com/AdityaSavara/MSRESOLVESG/issues/267
- [x] if UserChoices['measuredReferenceYorN']['on'] ='no' then the UserChoices['measuredReferenceYorN']['referenceFileStandardTuning'] = ['GasMixtureNISTRef.csv'] needs to be set to blank during user validity. Same thing for the existing pattern.
- [x] The variables referenceFileStandardTuning and referenceFileExistingTuning in userinput need to be changed to say "andForm" at the end of the variable name. Same for referenceFileDesiredTuning
- [ ] With the gas mixture tuning corrector, There is lots of printing of "moleculechooser" that is probably not intended. An optional argument or temporary turning off of verbose should be implemented for the relevant line(s).
- [x] After making a mixed reference pattern from tuning corrector, need to remove molecules again if chosen molecules is on and they are not in chosen molecules. Undesired behavior was observed in 211105BenDataAnalysisGasMixtureOneExperiment\7
- [ ] In workshop directory 8 https://github.com/AdityaSavara/MSRESOLVE_Workshop, there is a problem where the resolveConcentrations are not getting plotted. (maybe not calculated at all? or maybe calculated wrong? May need to print out matching_abscissa and other things to trace this issue.)
- [ ] IN workshop directory 8, there is a warning printed out about uncertainties not being completely programmed for tuning corrector.