search

AdityaSavara / PEUQSE

Parameter estimation for complex physical problems often suffers from finding ‘solutions’ that are not physically realistic. The PEUQSE software provides tools for finding physically realistic parameter estimates, graphs of the parameter estimate positions within parameter space, and plots of the final simulation results.
13 stars 5 forks source link

getLogP effiency optimization for when bounds are on. #199

Closed AdityaSavara closed 2 years ago

AdityaSavara commented 2 years ago

Currently, there is a parameter bounds check in the likelihood. We should consider the following:

(a) Move getting the prior earlier than the likelihood in getLogP (b) skipping the getLogLikelihood call if the prior is probability of 0. (c) removing the parameter bounds check from getLogLikelihood. it will become superfluous if the above two changes are made.

In principle, we could put the bounds check in getLogP to avoid the prior call, but I don't think that's a good idea. The prior definitely needs the bounds check in it, so better to just leave the bounds check in there.

AdityaSavara commented 2 years ago

This was already partially done, and has been completed Dec 6th 2021