search

AdityaSavara / PEUQSE

Parameter estimation for complex physical problems often suffers from finding ‘solutions’ that are not physically realistic. The PEUQSE software provides tools for finding physically realistic parameter estimates, graphs of the parameter estimate positions within parameter space, and plots of the final simulation results.
13 stars 5 forks source link

Heatmap and other plotting improvements #234

Closed TroyGustke closed 2 years ago

TroyGustke commented 2 years ago

Do not merge yet. I am trying to improve the number of ticks and commenting.

AdityaSavara commented 2 years ago

Make another comment or email me to let me know once it's ready to merge.

TroyGustke commented 2 years ago

The branch is ready to merge. The attached file has all the plotting options shown and an example of them being used for both scatter matrix and heatmap. The contour plots are equivalent looking to previous versions. 220610_plotting_options_testing.docx

AdityaSavara commented 2 years ago

@TroyGustke Now that I am looking at this, I think that rather than "max_y_ticks" it should be "max_num_y_ticks" and "max_num_x_ticks" because otherwise it can be mistaken for the axis maximum value

AdityaSavara commented 2 years ago

The branch is ready to merge. The attached file has all the plotting options shown and an example of them being used for both scatter matrix and heatmap. The contour plots are equivalent looking to previous versions. 220610_plotting_options_testing.docx

Please add the plotting options testing into the repository as ExamplesAndTutorialAndGettingStartedAppendix2.docx

TroyGustke commented 2 years ago

I have addressed all the comments. I actually had to make an algorithmic change for the individual plots for scatter matrix and heatmap. I changed variable names and added several more comments to this section of code. If this still does not look like descriptive code, could you help me with the language?