Adldap2 / Adldap2-Laravel

LDAP Authentication & Management for Laravel
MIT License
911 stars 185 forks source link

Please release a new tag v4.0.8 that uses ^9.0 instead of ^8.0 #585

Closed acacha closed 6 years ago

acacha commented 6 years ago

Currenly we cannot use new features 9.0...See:

https://github.com/Adldap2/Adldap2-Laravel/blob/v4.0.7/composer.json

stevebauman commented 6 years ago

Hi @acacha, this is intended, as v9.0 includes breaking changes in the query builder and other aspects (such as the configuration files) that may impact developers Laravel applications.

It will be a v5.0 release to follow semver.

It will be coming in a couple days!

acacha commented 6 years ago

agghh ok sorry! No problem. Thanks!

stevebauman commented 6 years ago

No problem, thanks for your patience! :smile:

KuenzelIT commented 6 years ago

Hi,

will there be some kind of upgrade guide? I'm also looking forward to this to fix the problem with getting contacts when searching for users.

Thanks!

stevebauman commented 6 years ago

Hi @KuenzelIT, there will definitely be an upgrade guide.

There won't be many breaking changes, only small configuration & query builder changes, but they are indeed breaking so it requires a major version.

Thanks for your patience guys!

m-lotze commented 6 years ago

v4.0.10 upgraded adldap to v9.

is this intended? it broke quite a lot...

stevebauman commented 6 years ago

Hi @m-lotze, just caught this. Created a release from the v4.0 branch and it seemed to use the new composer.json file using v9.0...

I'm going to re-create the release (I've deleted v4.0.10 for now). I might have done this somehow, just not sure how.

stevebauman commented 6 years ago

@m-lotze New release is now good to go, sorry about that! 🤦‍♂️

I think I may have selected the master branch when pushing.

jwhulette commented 6 years ago

Is there an update when the v5 will be released?

stevebauman commented 6 years ago

Hey @jwhulette, will be coming this upcoming week!

There’s a lot of breaking changes I need to document and still need to write the upgrade guide.

stevebauman commented 6 years ago

Released.