search

Admidio / admidio

Admidio is a free open source user management system for websites of organizations and groups. The system has a flexible role model so that it’s possible to reflect the structure and permissions of your organization.
https://www.admidio.org
GNU General Public License v2.0
336 stars 131 forks source link

Vorstand is not allowed to edit username of new registrations #1412

Closed sielnet closed 1 year ago

sielnet commented 1 year ago

Describe the bug members of the vorstand role of our org are not allowed to edit user-names during new member approval. It used to work until a few weeks ago. We only updated admidio + addons in the meantime since it used to work and did not change anything else.

To Reproduce Steps to reproduce the behaviour:

  1. New user registers via declaration of membership plug-in
  2. Vorstand sees the registration under new registrations
  3. vorstand is allowed to 1. edit the new members profile and 2. accept the registration
  4. vorstand is not allowed to set the username/loginname for the new member during "1. edit the new members profile" (does not see the username field at all)

Expected behaviour Before one of the latest updates it was possible for Vorstand role to edit usernames of new members during approval.

Screenshots If applicable, add screenshots to help explain your problem.

System (please complete the following information):

Additional context To clarify things a little bit more: New users registers via the declaration of membership plugin. The new user is only allowed to suggest a user name via a "choose user name" field in the registration form. Vorstand sees the new registration. Vorstand does two things to add new members:

  1. vorstand clicks on the new user and checks the profile information (in the new registrations screen on the left side)
  2. vorstand copies the value of "choose user name" field into the "user name" field and saves the profile
  3. vorstand accepts the registration (in the new registrations screen on the right side)
Fasse commented 1 year ago

The username is a very personal information and field. Only administrators should edit it for administration issues.

Why should someone change the username of a person that the person himself chooses?

sielnet commented 1 year ago

I do understand your view. We used this as a workaround because we were not able to add the user name field in the registration form of DeclerationOfMembership. That was the reason we needed a "I want this user name" field. And the copy paste of the wanted user name to the real/right user name field was done during approval of new registrations.

I will fix original issue. It makes sense the fix the registration form of DeclerationOfMembership and to drop this workaround.

Fasse commented 1 year ago

That sounds good. The declaration of membership should ask for the username and Save that value.