search

Admidio / admidio

Admidio is a free open source user management system for websites of organizations and groups. The system has a flexible role model so that it’s possible to reflect the structure and permissions of your organization.
https://www.admidio.org
GNU General Public License v2.0
336 stars 131 forks source link

Cannot set end date for Role Leader, with two leaders #1542

Closed Rvice closed 8 months ago

Rvice commented 10 months ago

Describe the bug We have a change in officers and the structure we have is that the Vice President is the Leader of the other Role (Board in this case). When we had our elections in December 2023, I added the new Vice President starting 1/1/2024 and then attempted to set the 2023 Vice President "Board" role to terminate 12/31/2023.

What's happening now though, is that I cannot set an end date to the outgoing vice president (2023) or remove the "leader" role from the user as well. Note, now that it is 2024, the 2023 vice-president no longer has vice president as an active role (it's now former).

To Reproduce Steps to reproduce the behavior:

  1. I'll need to play around in playground to see if I can replicate this.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots Showing board role only for 2023 vice president image

Showing history of 2023 vice president image

2024 Vice President and former image

Observe in the 2024 vice president, the "Associations Board" is not listed twice as it is on the 2023 vice president.

System (please complete the following information):

Additional context

Fasse commented 10 months ago

Could you please have a look in the playground and if this behavior is still available with Admidio 4.3 ? I made some changes to the logic how roles will be assigned.

The old behavior in 4.2 will delete former role assignments if you assign the same role again :(

Rvice commented 10 months ago

It's not "broken" but the behavior is a little weird.

The user that is becoming "Leader" gets removed from the role (Associations Board) but becomes leader on the last day. I was sort of expecting the person to continue being within the role and not going to "former"

i.e. being Leader is also a member of the Role. I suppose some organizations, the leader may not be part of the role as well, however, not in our case.

Fasse commented 10 months ago

Could you please explain me step by step what you have done., so I could reproduce the problem.