search

Admidio / admidio

Admidio is a free open source user management system for websites of organizations and groups. The system has a flexible role model so that it’s possible to reflect the structure and permissions of your organization.
https://www.admidio.org
GNU General Public License v2.0
336 stars 131 forks source link

Make contacts module search case-insensitive #1617

Closed robertoschwald closed 7 months ago

robertoschwald commented 7 months ago

Is your feature request related to a problem? Please describe. In the old Member module, the search was case-insensitive. In the new Contacts module, it is case-sensitive.

Describe the solution you'd like Make the search case-insensitive again, as otherwise, it could be problematic to find the entries.

Describe alternatives you've considered ./.

Additional context ./.

Fasse commented 7 months ago

Within my tests in our demo area, the search in contact module is still case-insensitive. Could you please provide an example where the search is case sensitive?

robertoschwald commented 7 months ago

Here we go: In Contacts, search for "muster" doesn't show a hit. Searching for "Muster" shows a hit.

lowercase uppercase
robertoschwald commented 7 months ago

I'm on MariaDB 10.5. Tables are CHARSET=utf8 COLLATE=utf8_unicode_ci.

In the docker-compose example, you use MariaDB 11.1, where Contacts search is case-insensitive.

If I change the SQL queries to use explicit LOWER() on the queried fields and the contatenated query, it works independent of the db collation. Maybe thats a way to enhance the code.

robertoschwald commented 7 months ago

I added a PR for this . https://github.com/Admidio/admidio/pull/1621

Fasse commented 7 months ago

Thanks for the fix. That explains why I could Not reproduce the problem.