Admidio / admidio

Admidio is a free open source user management system for websites of organizations and groups. The system has a flexible role model so that it’s possible to reflect the structure and permissions of your organization.
https://www.admidio.org
GNU General Public License v2.0
304 stars 122 forks source link

Wrong column adjustment if profilefields not visible for members #271

Closed thomas-rcv closed 8 years ago

thomas-rcv commented 8 years ago

If a list configuration contains profilefileds with property "only visible for users with rights", the column adjustment doesn´t fit in the datatable. There we have problems with the cellspacing to the headline. In case of the profile field "lastname" the problem extends also to the own list configuration. The first line would be empty and this would throw an error message.

See Forum: http://www.admidio.org/forum/viewtopic.php?f=3&t=6788

demo-organisation - liste - mitglieder - mozilla firefox_2016-01-03_22-06-09

demo-organisation - eigene liste - konfiguration - mozilla firefox_2016-01-03_22-06-42

demo-organisation - hinweis - mozilla firefox_2016-01-03_22-07-11

thomas-rcv commented 8 years ago

@ Ximex Please have a look if the cs-fixer is working correctly within this commit.

I don´t understand why it set a dot point in the remark field at the beginning of the script. Do we cancel the brackets within a require_once statement?

ximex commented 8 years ago

@thomas-rcv this looks strange. it looks like you have ALL fixes enabled or something else.

thomas-rcv commented 8 years ago

I used the config file as recommended by you. It is the config file out of the branch 3.1

Hmm don´t know where the Problem is.

This was my command:

php php-cs-fixer.phar fix --config-file="C:\xampp_1.8.3\htdocs\Admidio-Branches\admidio.php_cs" --verbose --dry-run C:\xampp_1.8.3\htdocs\Admidio-Branches\admidio\adm_program\modules\lists\lists_show.php

ximex commented 8 years ago

should be: php php-cs-fixer.phar fix --config-file="C:\xampp_1.8.3\htdocs\Admidio-Branches\admidio\.php_cs" --verbose --dry-run C:\xampp_1.8.3\htdocs\Admidio-Branches\admidio\adm_program\modules\lists\lists_show.php

look at the \ between admidio and .php_cs

thomas-rcv commented 8 years ago

ok, i see. how to repair now? run again?

ximex commented 8 years ago

best is a revert of this commit and do the changes again

Fasse commented 8 years ago

yes revert will be good.

thomas-rcv commented 8 years ago

ok, will try later.

Do a check again before the commit?

Fasse commented 8 years ago

maybe first commit only your changes than do the check and have a look at the changed lines if there are always so many lines than you should be skeptical and not commit again.

thomas-rcv commented 8 years ago

Yes, of course. Will do it later. I´m off now ;)