Feature use filesystemutils

[ximex]

use the new FileSystemUtils class and some code improvements

[ximex]

@Fasse please review and merge if all is ok

[Fasse]

@ximex before I start testing this, have you manually test your changes. Because this is something that could break our file handling ...

[Fasse]

I will check this after commit of menu so I could check compatibility also against those changes.

[ximex]

@Fasse now you could test. Fixed some small bugs

[Fasse]

There is a problem with the htaccess file. If the file doesn't exists, it won't be created with the new class. So the folder isn't protected.

[ximex]

On my server the creation of .htaccess works.

Which PHP Version? Windows or Linux? Any logs?

[Fasse]

I could reproduce it with my Mac and my Linux NAS.

To reproduce: I have a running Admidio installation folder adm_my_files and a htaccess file. Then I remove the htaccess file. Now go to downloads and create new folder -> no htaccess file is created

@ximex in which cases do we create that file?

[ximex]

only on update now. Look here: https://github.com/Admidio/admidio/blob/feature-use-filesystemutils/adm_program/installation/update_functions.php#L237 I could also add this code into common.php than it would be checked on any request. but i think on update it should be enough.

[Fasse]

Hmm, of you move your Installation to another webspace it should also be added. Check this at every request would be too mich, but maybe if we still handle with adm_my_files folder.

[ximex]

Or show it in the system-settings and add a button to create on if there is no .htaccess?

[Fasse]

Ok, also possible. But Check at update should still be there.

[ximex]

Ok than i will implement this

[ximex]

@Fasse done

[ximex]

@Fasse couldn't reproduce your problem. Please give more information.

[Fasse]

you can merge.