search

Admidio / admidio

Admidio is a free open source user management system for websites of organizations and groups. The system has a flexible role model so that it’s possible to reflect the structure and permissions of your organization.
https://www.admidio.org
GNU General Public License v2.0
336 stars 131 forks source link

browser-update Plugin/Setting #81

Closed ximex closed 9 years ago

ximex commented 9 years ago

Implement this update message with a plugin or to enable it with a setting https://browser-update.org/

Bullnados commented 9 years ago

+1

Fasse commented 9 years ago

It's not the Job of Admidio to Tell users to Update their browsers.

We should not implement such a service in our programm. Everyone could implement this on His homepage if he like.

ximex commented 9 years ago

I think every (modern) website should say their users to update their browsers to make the life of each webdeveloper easier and make the web faster and safer.

I read some years ago: The cost to optimize the website for IE makes about 20% of the full costs. (i think this isn't this bad in this days)

Fasse commented 9 years ago

If someone wants to implement this, then this should be optional and protected by a preference. The default should be off.

ximex commented 9 years ago

ok than i will look at this

ximex commented 9 years ago

where should i put the setting? Allgemeines at last point after Farbe Javascript-Editor?

Where is the best place to put the javascript code in? htmlpage.php?

Bullnados commented 9 years ago

BTW in the forum I asked if it is possible to create security menu. Put all the security stuff in it. I add the link tomorow

ximex commented 9 years ago

i only have to add the language files. But i have one bug. the $gPreferences didn't get updated if i edit a value. if i change the caching in "organization.php -> getPreferences()" i could see the change after a second refresh. Any ideas?

ximex commented 9 years ago

@Bullnados i don't think this is a security stuff. But a security menu is a good idea. Feel free the open an issue for that.

Fasse commented 9 years ago

@ximex Put it in Allgemeines at last point after Farbe Javascript-Editor. And yes, the javascript should be set in HtmlPage if the preference is set.

Have you run the update after you have edit the new preference?

ximex commented 9 years ago

@Fasse which update?

Fasse commented 9 years ago

The admidio Update, so that your prederence is added to the database and to the session.

ximex commented 9 years ago

@Fasse where can i find this function? but woudn't that mean that the other settings didn't get updated after save?

ximex commented 9 years ago

shouldn't this get done in "adm_program/modules/preferences/preferences_function.php" L 206-248 ?

Fasse commented 9 years ago

Sorry I misunderstood your problem. If you have a checkbox than you must add the preference to the checkbox array in line 50 in preferences_function.php

ximex commented 9 years ago

@Fasse i already had done this. maybe another bug in the master branch?

i will make a pull request

Fasse commented 9 years ago

hmm, don't know. Do you have a branch, where I can look at the code?

ximex commented 9 years ago

i'm working on this and will push a branch in some minutes

ximex commented 9 years ago

https://github.com/Admidio/admidio/commit/8f94bc53b2f1524f1f29287fb0147a63df573ce2

ximex commented 9 years ago

merged

Fasse commented 9 years ago

Have you Change the preference description?

ximex commented 9 years ago

yes. here: https://github.com/Admidio/admidio/commit/69f0c4f024c16977b22549934bf0f465d25ebb91 pull request: https://github.com/Admidio/admidio/pull/120