[QoL] Improving security via isolation + some refactoring. - Githubissues

Admiral-Billy / Pokerogue-App

An app to play Pokerogue.net in an app window. Wow!

MIT License

414 stars 68 forks source link

[QoL] Improving security via isolation + some refactoring. #143

Closed podarsmarty closed 1 month ago

podarsmarty commented 1 month ago

Removed unused params for electron window prefs
Removed window prefs to use default provided ones as they already specify context isolation and disabling of node integration
Refactored discord rpc updating to be its own file
Added void's to get rid of warnings about unused promises

Edit

noticed discord rpc only attempt connection when the app is first started. refactored the logic so that it will attempt to reconnect/update regardless of if discord is open first before the game starts, it will now update.
updated polling time to be 15 seconds since that seems to be the rate limit for discord

Admiral-Billy commented 1 month ago

I'll make sure this doesn't break linux or anything and then I'll merge it; presumably Mac is fine with these changes so y'know.