Admiral-Fish / PokeFinder

Cross platform Pokémon RNG tool
GNU General Public License v3.0
300 stars 73 forks source link

Allow IV filters to ignore inherited stats #398

Open c-poole opened 1 month ago

c-poole commented 1 month ago

Adds a third filter class DaycareFilter that each of the egg tabs now use, which has the option to ignore inherited stats for the purposes of filtering the results.

The primary utility I see for this feature is to make it so that searches for targets do not explicitly depend on the provided values of the parent IVs and instead provides a blueprint for what the parent IVs need to be to match the filters. This allows for a workflow pattern of identifying a target -> identifying parent targets to allow you to hit said target -> getting target parents/egg. This flexibility specifically allows for finding parent targets where you don't need to engineer both parents to have identical IV spreads to what you want your target to have, or to find options when you don't need an exact set of 6IVs on the egg and therefore fixing the parents to specific stats could filter out possibilities.

It also has some utility in gen 3 where there is an incomplete enumeration of the possible VBlank signatures, and therefore even if the user provides all the correct information for an egg they produced, they may not get a hit on any of the provided methods.

c-poole commented 2 weeks ago

Is this feature not desired? I personally often want to use the egg page as a way to both find egg targets but also identify what parents need to be to reach desired goals, which this facilitates better options for. It is an additional "thing for the user to think about" which may not be desired. Can definitely adjust implementation as needed if it is desired.

Admiral-Fish commented 2 weeks ago

I get side tracked easily. I'll try to look this weekend at this