Admiral-Fish / PokeFinder

Cross platform Pokémon RNG tool
GNU General Public License v3.0
317 stars 78 forks source link

Remove Gen 4 Generator "Delay" field #418

Closed NickPlayeZ closed 2 months ago

NickPlayeZ commented 3 months ago

I've seen that field be the cause of confusion for dozens of newcomers to RNG manip in the past few months and since there's already an "Initial Advances" field which offers largely the same functionality I don't believe it provides nearly enough value to justify peoples confusion. Or at the very least rename it so no one inputs their target Delay into that field.

Admiral-Fish commented 2 months ago

The fields serve fundamentally different purposes. I don't see the benefit in removing it.

Real96 commented 2 months ago

The fields serve fundamentally different purposes. I don't see the benefit in removing it.

I think the same, tge delay box is necessary. Maybe we can rename it, but removing it would be bad imo

NickPlayeZ commented 2 months ago

at least do rename it please yes; cause this way newcomers VERY OFTEN put their target delay in there

Real96 commented 2 months ago

I can confirm this happens, cause I've seen users new to rng doing this. The only "problem" is that the same box is called "Delay" in the other gens

SexyMalasada commented 2 months ago

My 'cheap' way of avoiding this when explaining or teaching RNG to newcomers, is to call the Delay you get when starting an encounter Delay, and the Delay from game startup that you target for a given Initial Seed Delay Frame; differentiating them clearly. Maybe calling the latter 'Delay Advancements' on subsequent PF releases?

Admiral-Fish commented 2 months ago

Would something like Offset make more sense?

SexyMalasada commented 2 months ago

Would something like Offset make more sense?

For the first kind (ie delay on encounter), that's actually a great name for it ngl - and keeps the startup counting value still referred as Delay!

Real96 commented 2 months ago

Something like Advances Delay imo would be better

SexyMalasada commented 2 months ago

Something like Advances Delay imo would be better

for which of the values though?

Real96 commented 2 months ago

Something like Advances Delay imo would be better

for which of the values though?

Delay -> Advances Delay

In gen4 generator tab of each rng type

SexyMalasada commented 2 months ago

Oh I just remembered another possible option, which would standardize it with 3DSRNGTool! image

But either of the options here sound good to me!

NickPlayeZ commented 2 months ago

personally id prefer offset too; something that doesnt include the word "delay" so theres no chance anyone can confuse it