Admiral-Fish / PokeFinder

Cross platform Pokémon RNG tool
GNU General Public License v3.0
307 stars 75 forks source link

[Gen 5] Wild beta branch missing delay of 1 for Special Grass Encounter #421

Open SexyMalasada opened 2 weeks ago

SexyMalasada commented 2 weeks ago

Hello

I noticed today that in the Beta Gen5 Wild branch of PokéFinder, when searching for Special Grass encounters, it does not account for the delay of 1 that these encounters have vs normal grass encounters. As an example for comparison, I give the generator tab of PF and Generator of RNG Reporter for the same profile and seed. image image This isn't that urgent or important to fix ASAP, but just thought I'd mention! However the next issue definitely is!

Lmk if you need anything else, and hope you can address this!

Real96 commented 1 week ago

As a separate (but kinda related issue?) I wanted to test to see if this happened for the Surfing and Fishing options too, and to my surprise, it appears that clicking the 'Generate' button when using either Special Surfing or Special Fishing Encounter types in the Generator tab, will simply crash the program!

Lmk if you need anything else, and hope you can address these!

Separate the issues

SexyMalasada commented 5 days ago

As a separate (but kinda related issue?) I wanted to test to see if this happened for the Surfing and Fishing options too, and to my surprise, it appears that clicking the 'Generate' button when using either Special Surfing or Special Fishing Encounter types in the Generator tab, will simply crash the program! Lmk if you need anything else, and hope you can address these!

Separate the issues

Done!