search

Admiral-Fish / RaidFinder

Crossplatform RNG tool for Pokemon Sword/Shield raids
GNU General Public License v3.0
179 stars 54 forks source link

Shiny Type Calculation Problem #12

Closed dewblackio2 closed 4 years ago

dewblackio2 commented 4 years ago

I've been in the process of calculation den seeds, and noticed that after targeting Den #49 (in tool) #82 (on serebii), the seed that was retrieved had shiny results appear correctly in version 1.3.2.

However after updating to 1.3.3 the seed was input again, and there were no shiny results at all.

The seed in question: 0xCFA738978AFDFB33

Here are some images taken from the listed versions containing the information as well as inputs to show it is not user error:

Version 1.3.2: Version 1.3.2

Version 1.3.3: Version 1.3.3

The inputs didn't change, they were exactly the same. I do believe either the Den contents were updated in recent commits and weren't noted, or the shiny type calculation broke with recent changes.

Admiral-Fish commented 4 years ago

I released a hot fix for 1.3.3 to fix an issue with shiny type calculation.

Can you redownload and test again to make sure you have the hotfix edition?

dewblackio2 commented 4 years ago

I released a hot fix for 1.3.3 to fix an issue with shiny type calculation.

Can you redownload and test again to make sure you have the hotfix edition?

Do you have a link for the hotfix edition? I just pull from your releases on github, and I do not see an installer/zip for x64 windows labeled "hotfix"

Edit: my apologies its in the sub description of the 1.3.3 release. I will re-download and test again.

Admiral-Fish commented 4 years ago

I just redid the release. The notes contain hotfix at the top.

If you just redownload 1.3.3 it will contain the hotfix.

dewblackio2 commented 4 years ago

That hotfix seems to have fixed the issue.

Version 1.3.3

dewblackio2 commented 4 years ago

Thank you for the prompt response, and quick fix to the issue!