search

Admiral-Fish / RaidFinder

Crossplatform RNG tool for Pokemon Sword/Shield raids
GNU General Public License v3.0
179 stars 54 forks source link

drop down UIs are broken on macOS Mojave (QDarkStyle) #23

Closed matxx closed 3 years ago

matxx commented 4 years ago

all drop downs have huge empty spaces on macOS Mojave

screenshots are from 1.3.3 but the problem still exists on 2.0.0

image

image

image

edit : they are still functionnal (to select things), just some weird spaces

Admiral-Fish commented 4 years ago

What if you change the style to light?

armisael commented 4 years ago

Switching to light style fixes the issue, so I guess this should be notified to https://github.com/ColinDuquesnoy/QDarkStyleSheet/ ?

daphnegold commented 4 years ago

Came here to also create an issue about this. Interesting that changing the style to light fixes it. Thanks so much for your quick response @Admiral-Fish !

matxx commented 4 years ago

yeah, light style fixes the issue haha

Admiral-Fish commented 4 years ago

Any UI issues that I don't experience myself I can usually blame on the stylesheet. There is already an open issue on their repo for it.

https://github.com/ColinDuquesnoy/QDarkStyleSheet/issues/200

johnmquick commented 4 years ago

I also experienced this problem with the drop-down menus on Mac OS 10.15.3. By chance, I changed from dark mode to light mode and the drop-down menus now appear to be displaying properly. I don't know if it is related to which mode is selected or the fact that I changed modes.

johnmquick commented 4 years ago

Update: This only appears when selecting the dark theme.

Abu-ZaydAbdullah commented 4 years ago

There is actually an aesthetic fix for this if you are willing to build from source. Simply add height: 18px; to the QComboBox::item:checked class in QDarkStyleSheet/qdarkstyle/style.qss which at the time of writing starts at line 1263.

Admiral-Fish commented 3 years ago

Fixed by fa3fafa