Admiral-Piett / goaws

AWS (SQS/SNS) Clone for Development testing
MIT License
779 stars 144 forks source link

Add Support For Posting To Subscription Endpoint Over HTTP/S #173

Closed conatus closed 5 years ago

conatus commented 6 years ago

Thanks for your work on this library.

For the purposes of writing end to end tests, we'd love it if the SNS publish method actually pushed out a HTTP/S endpoint if the subscription had http set as its protocol. I can see it already does this for the faked SQS service. https://github.com/p4tin/goaws/blob/master/app/gosns/gosns.go#L305-L346

So the task would be something like:

Happy to try to add this feature but wanted to make this issue before I do just in case you had thought on the implementation or believe this is something out of scope for this application.

p4tin commented 6 years ago

I like this enhancement I have add a change request open for a while but have not looked into implemented it yet (change #75) but i am happy to entertain a pull request for this functionnality

p4tin commented 5 years ago

This was implemented under PR #175