search

Admiral-Piett / goaws

AWS (SQS/SNS) Clone for Development testing
MIT License
778 stars 145 forks source link

Add option to derive queue url host, tidying up logging levels #234

Closed nhoughto closed 1 year ago

Admiral-Piett commented 1 year ago

@nhoughto @AndrewChubatiuk Sorry this took ages to respond to, I'm ramping up on this after taking of the repo. Looks like you guys have 2 pretty similar PR's out there. This one and @AndrewChubatiuk 's here - https://github.com/Admiral-Piett/goaws/pull/213.

It looks like you're wanting to determine the host from the incoming header as opposed to just automatically routing to resources on the same host that's accepting your request. If that's true, what's your use case for this pattern? Are you running multiple goaws instances at once and wanting to route requests between them?

Admiral-Piett commented 1 year ago

Following up here @nhoughto @AndrewChubatiuk - would you mind speaking a little more to my question here around the use case on this?

https://github.com/Admiral-Piett/goaws/pull/234#issuecomment-1495215750

AndrewChubatiuk commented 1 year ago

hey @Admiral-Piett i was trying to query service from both host and docker networks that why goaws should return a valid urls depending on a network it was queried from

Admiral-Piett commented 1 year ago

@AndrewChubatiuk @nhoughto Closing this as a duplicate in favor of https://github.com/Admiral-Piett/goaws/pull/213. I am still reviewing the implementation, but I think the logging features and some of the other additions could be separate PRs. If they're still something either of you wants to move forward with - let's discuss them further.