search

Admiral-Piett / goaws

AWS (SQS/SNS) Clone for Development testing
MIT License
770 stars 145 forks source link

waitTimeSeconds being set to default even if developer called it with 0 #240

Open Ayman-Sage opened 2 years ago

Ayman-Sage commented 2 years ago

we just came across this issue when trying to set waitTimeSeconds to 0 which means don't do "long polling" and just look now without waiting.. but in the code it is always being set to default if it was passed as 0... is this intentional?

https://github.com/p4tin/goaws/blob/ba73e9b3195a592346488cab2dcaf61807605184/app/gosqs/gosqs.go#L412

Admiral-Piett commented 10 months ago

@Ayman-Sage Hm - I need to dig a little deeper on this, but I think that's probably just a relic of initializing that variable with 0 and assuming that means it wasn't overwritten. I'll think about this - since I think you're right, you should have the ability to "receive it NOW".