search

Admiral-Piett / goaws

AWS (SQS/SNS) Clone for Development testing
MIT License
770 stars 145 forks source link

Update permissible SNS endpoint call response codes #244

Closed nicolas-miller-storable closed 1 year ago

nicolas-miller-storable commented 2 years ago

https://docs.aws.amazon.com/sns/latest/dg/SendMessageToHttp.prepare.html

When an SNS subscription calls its endpoint, Amazon recognizes responses in the range of 200-499 as successful Notification deliveries. Responses outside of that range will trigger the Subscription's retry policy.

This PR updates the callEndpoint method to allow this range instead of just response codes divisible by 200.

YixingCheng commented 1 year ago

Wanted to make the same change.

nicolas-miller-storable commented 1 year ago

I don’t have write access to merge this. What happens next? No rush. I’m just curious.

dhumphreys01 commented 1 year ago

Hm, still figuring out how all this is set up. I'll take a look at the settings for the future but of course, I merged it for now! Thanks again for having a look at this!

fffinkel commented 1 year ago

This merge broke the app. Submitted #256 with the fix.