search

Admiral-Piett / goaws

AWS (SQS/SNS) Clone for Development testing
MIT License
788 stars 146 forks source link

add HOT-RELOAD feature and tests #261

Open apavanello opened 1 year ago

apavanello commented 1 year ago

260

Admiral-Piett commented 1 year ago

@apavanello Nice, this looks awesome. Just to clarify here - all you're enabling for Hot Reload is the queues and the topics themselves, correct? The other things, Log File/Region/QueueAttributes/etc. those look omitted from StartWatcher.

Admiral-Piett commented 1 year ago

@apavanello This change looks good, but it looks like it needs a rebase now. I have been playing with it today and it looks like this conflicts with some of the tests. I think they're treading on each other's memory addresses.

Anyway - I have a branch locally with some refactoring. I'll push it when I can if you want to see - though it will be significant, not all particularly related to your code. Thought, if you could share your k8 use case that would be really helpful - I want to make sure whatever I come up with matches your needs too.

In the meantime, if you want to rebase this and get it working that works too and I'll merge it. Up to you! Let me know!

apavanello commented 1 year ago

Hello there. Sorry, I've been working on a new project at work for the past few months, and it's been taking up a lot of my time. I need to look at the code again because I don't remember some of the details completely. I'll try to do it tonight when I'm done working.

But I can tell you that in the case of fsnotify.Remove, it's for if you want to use goaws in a Kubernetes environment. Kubernetes doesn't send clear signals of file changes or creation, it only sends a remove when the file state changes in a configmap.

Admiral-Piett commented 1 year ago

Ah, I can totally understand that alternate project business, story of my life. 😀 I have a sizeable PR that I'll probably want to incorporate anyway, but I'll incorporate whatever you come up with too. Alternately you can review my code when it's ready. I'm fleshing out some tests but I think it's nearly ready. I'll play with the k8 use case to make sure I'm capturing it to. Thanks for the info!

Admiral-Piett commented 1 year ago

@apavanello So - I am throwing this out there as a new PR. The more I got into it, the more I realized it's a major feature. but my PR has your commits in there too. I want to do a few things on this since operating in this memory space is just hard.

I would say - if you want to take yours over the line, go for it. I will rebase, if not, I'll do what I can. Also, if you have the bandwidth to keep an eye on it for your own use cases I'd appreciate it.

https://github.com/Admiral-Piett/goaws/pull/282