search

Admiral-Piett / goaws

AWS (SQS/SNS) Clone for Development testing
MIT License
788 stars 146 forks source link

allow for queue specific visibility time out configuration #264

Closed qhenkart closed 1 year ago

qhenkart commented 1 year ago

Currently there can only be a single VisibilityTimeout configuration that affects all queues. However in real life situations, some queues process more complex data than others requiring queue specific VisibilityTimeout settings. This PR simply updates the configuration so that queue specific visibility timeouts are also accepted

Admiral-Piett commented 1 year ago

@qhenkart This looks awesome, thank you! I will merge it shortly to be in the next release.

Admiral-Piett commented 1 year ago

@qhenkart I had to make some updates lately - would you mind rebasing this (so git can track the commit back to you and show your fine work 😉 )?

If you don't want, feel free to have a look at this? I rebased here - https://github.com/Admiral-Piett/goaws/pull/280.

qhenkart commented 1 year ago

@Admiral-Piett thank you! I will do it right away

qhenkart commented 1 year ago

@Admiral-Piett are you using an alternative to Gofmt? I'm seeing a lot of inconsistent spacing and unusual amount of auto format changes in the rebased PR

Admiral-Piett commented 1 year ago

@qhenkart No I'm not, but I am reformatting lots of files as I go. I think it will work itself out eventually, though I know it's an irritant to look at when you're reviewing.

Also, I'm going to close this. I'm sorry - I didn't notice your response until I after I merged this one - https://github.com/Admiral-Piett/goaws/pull/280. It should have been just a rebase of yours anyway. If there's anything I missed or anything I misrepresented let's talk?

Admiral-Piett commented 1 year ago

This was rebased and merged in an alternate PR: https://github.com/Admiral-Piett/goaws/pull/280