search

Admiral-Piett / goaws

AWS (SQS/SNS) Clone for Development testing
MIT License
788 stars 146 forks source link

Fix erroneous "not found" responses in DeleteMessageBatch #278

Open adventureisyou opened 1 year ago

adventureisyou commented 1 year ago

When looping through messages, the "deleted" indicator was being updated in the copy of deleteEntry within the loop rather than updating the slice which is later used to append "not found" errors, so both successes and fails were being returned.

Admiral-Piett commented 1 year ago

@adventureisyou Your change for this looks good, but I think we also need to include a fix for this line. https://github.com/Admiral-Piett/goaws/pull/278/files#diff-e4a9df642f75a9a1287dc9408df6d0de9c9680711caa7d621db50bdd832e4daeR668. I think it needs to be if !deleteEntry.Deleted - otherwise we'd still get the deleted entries in both places.

Would you mind taking care of that update, and throwing a test or so here for it?

Admiral-Piett commented 10 months ago

@adventureisyou Quick follow up on this, any thoughts on my previous comment?