search

Admiral-Piett / goaws

AWS (SQS/SNS) Clone for Development testing
MIT License
788 stars 146 forks source link

[Super rough proposal] support aws-json #285

Closed kojisaiki closed 8 months ago

kojisaiki commented 11 months ago

Here is my small try to adopt aws-json by #279

If I get feedback, I would like to continue development!

ref: https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-making-api-requests-json.html

ndench commented 11 months ago

This is great work!

What else do you think is necessary to finish this off?

From my perspective, the implementation seems to work fine. But you've only really tested one API call.

Perhaps we can get some sort of abstraction or helper function which makes it very easy to add AWS-JSON tests for all the other API calls too?

kojisaiki commented 11 months ago

This is great work!

What else do you think is necessary to finish this off?

From my perspective, the implementation seems to work fine. But you've only really tested one API call.

Perhaps we can get some sort of abstraction or helper function which makes it very easy to add AWS-JSON tests for all the other API calls too?

Yes, this work should have more refactoring. e.g.

  1. Should handle "Action" at router.
  2. Should separate the formValue handling logic from low-level SQS/SNS logic.
mancej commented 10 months ago

Running into this issue as well and strongly support this fix! :)

kojisaiki commented 10 months ago

Thank you guys for comments!

I also think that supporting aws-json will become a big refactor, so now I'm discussing with my company to have a plenty of time to contribute to this work.

How about creating a new feature branch in this Admiral's repository and create partial PRs to the feature branch ? We will be able to divide this work among people who can do it.

Admiral-Piett commented 10 months ago

@kojisaiki Great idea! I just made this - https://github.com/Admiral-Piett/goaws/pull/288, I tried to pull the changes from your fork in, and I think I got them all. If you have anything new I missed, feel free to have a whack at it. Let's migrate the future discussions over there if that works.

I'll try to have have proposal up for a more unified approach as soon as I can though, apologies in advance, it might take me a a few days to make some time for it, since I'm finishing up a few other things right now.

kojisaikiAtSony commented 10 months ago

I'm explaining this to the company and getting their approval to contribute, so please wait a little while...

kojisaikiAtSony commented 9 months ago

@Admiral-Piett Sorry for the long wait, but I received approval to contribute using my company time! I'm currently too busy to create PR right away, but I expect to be able to start working on it by mid-March.

kojisaiki commented 8 months ago

I cancel my very initial proposal. Our latest try is in V1 flow.