Admiral-Piett / goaws

AWS (SQS/SNS) Clone for Development testing
MIT License
788 stars 146 forks source link

Include Owner value in Subscriptions and SubscriptionsByTopic responses #287

Closed chrisdaly3 closed 10 months ago

chrisdaly3 commented 10 months ago

I added the Owner field for both the ListSubscriptions and ListSubscriptionsByTopic requests, as well as added tests to confirm the field is populated with the expected value in the response.


-> ListSubscriptions

image

-> ListSubscriptionsByTopic

image

Note - sorry it took so long to get to this one!! Luckily the changes were pretty straightforward, and the tests are passing smoothly. Let me know if you have any questions 👍

Admiral-Piett commented 10 months ago

This looks great to me, thanks for looking into it! I rebased it and re-ran the checks, if those pass I shall merge it!