search

Admiral-Piett / goaws

AWS (SQS/SNS) Clone for Development testing
MIT License
788 stars 146 forks source link

[aws-json] Migrate SNS ConfirmSubscription API #322

Closed kojisaikiAtSony closed 2 months ago

kojisaikiAtSony commented 2 months ago

Now we don't have any smoke test for ConfirmSubscription because to perform the complete ConfirmSubscription feature requires the email destination and HTTP server. Additionally, currently Subscribe API does not support "pending" status and don't send an email even if the endpoint is an email address.

kojisaikiAtSony commented 2 months ago

Hi @Admiral-Piett, we tried to migrate the API but we have few comments. Could you please check them?

Admiral-Piett commented 2 months ago

Now we don't have any smoke test for ConfirmSubscription because to perform the complete ConfirmSubscription feature requires the email destination and HTTP server. Additionally, currently Subscribe API does not support "pending" status and don't send an email even if the endpoint is an email address.

That's ok since this is an internal endpoint anyway. I'm fine to skip that one for now. Thank you!

kojisaikiAtSony commented 2 months ago

@Admiral-Piett Rebased!