search

Admiral-Piett / goaws

AWS (SQS/SNS) Clone for Development testing
MIT License
788 stars 146 forks source link

Bugfix around message attributes on Publish(SNS), ReceiveMessages(SQS) #339

Closed kojisaikiAtSony closed 3 days ago

kojisaikiAtSony commented 2 weeks ago

We found 3 bugs around message attributes, as shown below:

  1. Received Message Attribute via XML is not decoded from base 64.
  2. DataType value was broken by caser unexpectedly.
    • The exact conditions have not been identified, but at a certain point when publish/receive messages are repeated, the DataType value String becomes a string like \u0000\u0000\u0000\u0000\u0000\u0000 due to the caser.
  3. MD5OfMessageAttributes is missing on the message with message attributes from SQS-ReceiveMessages.
kojisaikiAtSony commented 1 week ago

Finally - https://github.com/Admiral-Piett/goaws/pull/338 @toastwaffle did some good work on combining the logic around parsing incoming MessageAttributes.

The PR is very helpful! We'll rebase this once it is merged 👍

kojisaikiAtSony commented 3 days ago

@Admiral-Piett I'm really sorry for creating such a big and confusing PR without considering your burden 🙇 I will create separated, small PRs on each fixes.