CS3: Master Quartz buffs are broken when using the US executable.

AdmiralCurtiss / SenPatcher

Fixes and customizations for the Trails of Cold Steel games on Windows.

Other

88 stars 6 forks source link

CS3: Master Quartz buffs are broken when using the US executable. #46

Closed AdmiralCurtiss closed 3 years ago

AdmiralCurtiss commented 3 years ago

See https://www.reddit.com/r/Falcom/comments/jljan4/the_full_explanation_on_how_the_9_turn_master/

Summary: t_mstqrt.tbl swapped the effect and time values so that the sprintf() for the menu description works correctly. Devs, please just use fmt...

AdmiralCurtiss commented 3 years ago

The relevant snprintf_s() call is at 0x1402801b5, but unfortunately it's used for all master quartz descriptions so we can't just switch the parameter order.

So we have three options here:

Replace the snprintf_s() with a variant that supports positional arguments, then use those.
Swap the usage of the values in battle instead.
Or just give up and rewrite the descriptions.

AdmiralCurtiss commented 3 years ago

Fixed in v0.7, most likely.