AdmiralGT / ttennis_ladder

0 stars 1 forks source link

Add 3rd column to main page with cool random other stuff #14

Closed andrew-nubbert closed 7 years ago

andrew-nubbert commented 7 years ago

I think we want:

The "other stuff" could include:

ghost commented 7 years ago

Nice. Suggest giving the left and right "columns" a bit of top padding/margin, so the main results section is a bit more prominent.

andrew-nubbert commented 7 years ago

Yep. Maybe bigger font for the main rankings. Also try to make the other columns about the same height as the middle column (i.e. include more recent results), add a sensible amount of other stuff.

ghost commented 7 years ago

I've prototyped this (branch issue14) by adding a placeholder left column. Do we have any useful content to go in there?

AdmiralGT commented 7 years ago

At the moment know, we could have a biggest upset in most recent X games?

andrew-nubbert commented 7 years ago

One thing to check is that having 3 columns doesn't cause wrapping or otherwise bad formatting on lower resolutions.

Also I think it's worth adding the text below in the left column even if there's no other content for it yet. Having the extra column moves the actual rankings to the middle where they are more prominent.

Points difference: Expected win % 100: 64% 200: 76% 300: 85% 400: 91% 500: 95% 600: 97%

ghost commented 7 years ago

I think the only way to avoid wrapping/bad formatting is to have a container div with a fixed width. Means that lower resolution screens will have a horiz scroll bar, but I'm OK with that. (this doesn't apply to phones, which we'll need to do a complete restyle for).

andrew-nubbert commented 7 years ago

I think we've got enough content for the left column already:

ghost commented 7 years ago

Left column feels a bit narrow for some of this content. Expected win percentage probably just about fits, but not sure about the rest.

Suggest adding a separate "about page" instead, then it might also make sense to have a permanent nav bar with "home" and "about" links.

ghost commented 7 years ago

I've put all the extra info on the new "about" page, so now it's just the expected win %age in the left hand column, which is a bit too sparse. Suggest we hold off on the three columns until we have more dynamically generated content to put into the left hand column, e.g. biggest shocks of the month.

ghost commented 7 years ago

The main column is a little wider, after update to win/loss entries. This means that if we do add a third column it'll be even narrower than it was previously. Suggest we just stick with two columns. If/when we ever add cool new features, they can go in the secondary column (e.g. under the current recent results table). Comment/ reopen this if you disagree.