AdmiralenOla / Scoary

Pan-genome wide association studies
GNU General Public License v3.0
147 stars 35 forks source link

error #77

Closed darwinbandoy closed 4 years ago

darwinbandoy commented 5 years ago

Hi,

I keep getting this error message when I ran Scoary on my Roary Output:

CRITICAL: Traceback (most recent call last): File "/miniconda3/envs/scoary/lib/python3.6/site-packages/scoary/methods.py", line 268, in main strains) File "miniconda3/envs/scoary/lib/python3.6/site-packages/scoary/methods.py", line 568, in Csv_to_dic sys.exit("Make sure the top-left cell in the traits file " SystemExit: Make sure the top-left cell in the traits file is either empty or 'Name'. Do not include empty rows Make sure the top-left cell in the traits file is either empty or 'Name'. Do not include empty rows

This my trait CSV file and there seems to be no error with the traits file.

Name,Abortive,Non_Abortive B197.11581,0,1 B197.7887,0,1 B197.7889,0,1 B197.789,0,1 B197.7927,0,1

What could be the issue? Thanks

sam-mic commented 4 years ago

It may include <U+FEFF> before Name. Don't generate csv by Microsoft office. Check by less command.

AdmiralenOla commented 4 years ago

Hi @darwinbandoy and apologies for answering to this so late. Most probably @sam-mic has the correct answer - You have an invisible U+FEFF byte order mark in your file.

darwinbandoy commented 4 years ago

I corrected the <U+FEFF>, thanks.

However I still get this error message

CRITICAL: Traceback (most recent call last): File "/Users/miniconda3/envs/scoary/lib/python3.6/site-packages/scoary/methods.py", line 268, in main strains) File "/Users/miniconda3/envs/scoary/lib/python3.6/site-packages/scoary/methods.py", line 579, in Csv_to_dic "values (no commas): %s" % str(",".join(allowed_values))) SystemExit: Unrecognized character found in trait file. Allowed values (no commas): 0,1,NA,.,-, , Unrecognized character found in trait file. Allowed values (no commas): 0,1,NA,.,-, ,

AdmiralenOla commented 4 years ago

@darwinbandoy - Could you e-mail your input files to olbb@fhi.no and I'll have a look?

AdmiralenOla commented 4 years ago

Thanks, @darwinbandoy

I have had a look at your input files. Here are the two things that let me run Scoary without issues:

  1. Make sure you are giving Scoary the correct column for where your gene data starts. By default, this is column 15 in Roary files. In your non-standard gene presence/absence file, it is column 2. Therefore, you need to run Scoary with "-s 2"
  2. There is not a perect overlap between the strains described in your gene presence/absence file and those in your traits file. In your gene presence absence file, you have "BCW_10131", but this isolate is not in your traits file. Further, your traits file has "BCW_10196", but this is not in your gene presence/absence file. When I deleted these respective entries from your files, Scoary was able to run without errors.

Please let me know if this fixes the issue for you too.

darwinbandoy commented 4 years ago

Hi Ola,

Thank you for taking the time to solve this. I was using the RTAB output of roary where the values are one hot encoded.

I will try to run it.

Thanks!

On Mon, Dec 9, 2019 at 1:44 AM Ola Brynildsrud notifications@github.com wrote:

Thanks, @darwinbandoy https://github.com/darwinbandoy

I have had a look at your input files. Here are the two things that let me run Scoary without issues:

  1. Make sure you are giving Scoary the correct column for where your gene data starts. By default, this is column 15 in Roary files. In your non-standard gene presence/absence file, it is column 2. Therefore, you need to run Scoary with "-s 2"
  2. There is not a perect overlap between the strains described in your gene presence/absence file and those in your traits file. In your gene presence absence file, you have "BCW_10131", but this isolate is not in your traits file. Further, your traits file has "BCW_10196", but this is not in your gene presence/absence file. When I deleted these respective entries from your files, Scoary was able to run without errors.

Please let me know if this fixes the issue for you too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdmiralenOla/Scoary/issues/77?email_source=notifications&email_token=AJZAZE2NQDFLKWGZD5AVEQ3QXYHRTA5CNFSM4HJRXAHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGIPUVQ#issuecomment-563149398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJZAZE576DSGDYWC3NW2HLLQXYHRTANCNFSM4HJRXAHA .

-- Dr. DJ Darwin R. Bandoy Assistant Professor Department of Veterinary Paraclinical Sciences College of Veterinary Medicine University of the Philippines Los Baños College Los Baños, Laguna, Philippines

akanksharawat07 commented 2 years ago

Hi Ola, I have encountered an error while running scoary, the .log file says something like this and the .result.csv file i am getting only has headers and no values in it.

Screenshot 2022-08-12 at 4 17 01 PM

can you please help me by explaining the error. thanks!

akanksharawat07 commented 2 years ago

also, instead of gene_presence_absence.csv, I have a mutation_presence_absence.csv which i am using as -g input parameter. Is it okay to use this .csv file. please help me with it.

AdmiralenOla commented 2 years ago

Hi @akanksharawat07. Most likely you just have no significant results with a p-value lower than 0.05. Try running with -p 1.0.

Also, in the future consider opening a new issue rather than posting on a closed, unrelated issue :-)