search

AdmiringWorm / chocolatey-package-requests

Please submit your package requests as issues here
Apache License 2.0
0 stars 0 forks source link

RFP - gep13-package #4

Open gep13 opened 4 years ago

gep13 commented 4 years ago

Checklist

Package Details

Software project URL : https://github.com/codecov/codecov-exe Direct download URL for the software / installer : https://github.com/codecov/codecov-exe/releases/download/1.11.1/codecov-win7-x64.zip Software summary / short description:

AdmiringWorm commented 4 years ago

Nope, still didn't work (this time in my script somewhere). I'll move over to a different issue for testing, then come back when it works again.

AdmiringWorm commented 4 years ago

/attach @gep13 gep13

^^ This is the reason why I asked on gitter if there was a way to check if a user exists or not. This command connects the GitHub user and the chocolatey user. It is meant for validation of RFM scripts to validate that the user opening the RFM is the maintainer (if they have selected as such). That validation isn't yet implemented, though. It also updates a file called users.json in the repository where it stores the connected users.

I also need to implement some validation that the user has write permissions to the repository (if they don't, they should only have access to /confirm chocolatey-user instead of attaching users).

I also plan to add additional scripts as well (for connecting packages to the request, validating if a package have been submitted and published and for assigning users to the request).

EDIT: Seems I had some kind of typo in the script, need to run it again 😞 EDIT 2: Seemed to fail because I didn't have the correct encoding on the PowerShell script. EDIT 3: Nope, it seems it was the github yaml file that didn't like the inline code spans. Sorry, had to delete the comment and add it again to make sure it works as expected. EDIT 4: Now it should work, but as you can see from the commit message https://github.com/AdmiringWorm/chocolatey-package-requests/commit/6fb939d886dd66f17a61fea35dee587ee59fdb20 I have no idea what I did 😆

github-actions[bot] commented 4 years ago

Chocolatey user gep13 has been connected to the github user @gep13

AdmiringWorm commented 4 years ago

^^ The github-actions bot also created the following commit: "https://github.com/AdmiringWorm/chocolatey-package-requests/commit/cbbdfd074a1af8aef3f6e999d1327a0c6c605f93" (The reason it says AdmiringWorm on the commit is because I created the comment, I may clean that up and have it as a co-author instead.)

AdmiringWorm commented 4 years ago

/recheck

github-actions[bot] commented 3 years ago

Package Request Validation

We have finished some basic validation of this request. The result of this validation can be found below:

Everything looks good to our automated checks, it is now up to a human to validate the remaining steps. No action is required yet

New Maintainer Notices

This section details some parts of the request that any upcoming maintainer may need to take into consideration.

File Validation Output ``` TrID/32 - File Identifier v2.24 - (C) 2003-16 By M.Pontello Definitions found: 13748 Analyzing... Collecting data from file: C:\Users\runneradmin\AppData\Local\Temp\software.tmp 80.0% (.ZIP) ZIP compressed archive (4000/1) 20.0% (.PG/BIN) PrintFox/Pagefox bitmap (640x800) (1000/1) ```

Please note that this check is currently in alpha, and may not be able to detect everything correctly. Humans may also be able to detect other issues with this request.