AdmitHub / Telescope

AdmitHub's telescope implementation
0 stars 5 forks source link

Add thumbnail images to the forum #11

Closed AndrewMagliozzi closed 8 years ago

AndrewMagliozzi commented 8 years ago

There is a telescope package for this:

https://github.com/TelescopeJS/Telescope/tree/master/packages/telescope-embedly

I've also added our Embedly API key to the settings on prod.

I've shared the account info with you @yourcelf too. I think we just need to add this image to our custom design.

@constantx can advise about specific look or just modify the style after we have the thumbnails in place.

In the meantime, we're doing a super hack by placing the image in the body of the question.

AndrewMagliozzi commented 8 years ago

you can see thumbnails working here too: http://demo2.telescopeapp.org/

yourcelf commented 8 years ago

What do you envision the thumbnails to be of in our installation?

The built-in embedly plugin takes a snapshot of the target page of the URL for a post. But none of our posts have URLs -- they're all "self" posts, just a title and sometimes a body.

AndrewMagliozzi commented 8 years ago

Ideally an image Dan uploads himself.

On Oct 7, 2015, at 8:17 PM, Charlie DeTar notifications@github.com wrote:

What do you envision the thumbnails to be of in our installation?

The built-in embedly plugin takes a snapshot of the target page of the URL for a post. But none of our posts have URLs -- they're all "self" posts, just a title and sometimes a body.

— Reply to this email directly or view it on GitHub.

yourcelf commented 8 years ago

So thumbnails should be editable by admins/officers? Should they be editable by regular users?

yourcelf commented 8 years ago

BTW, if we want to explicitly choose the thumbnail, we'll need to do this custom. The embedly implementation ties the thumbnail to the post URL and doesn't allow you to choose your own thumbnail.

yourcelf commented 8 years ago

Looks like this is implemented in https://github.com/AdmitHub/Telescope/pull/12 ?

AndrewMagliozzi commented 8 years ago

Yes