Lightbox fix - Githubissues

AdmitHub / Telescope

AdmitHub's telescope implementation

0 stars 5 forks source link

Lightbox fix #23

Closed ribner closed 8 years ago

AndrewMagliozzi commented 8 years ago

Hey Elliott, when you get a second, can you fix the conflicts between this branch and master?

AndrewMagliozzi commented 8 years ago

Can you also add a few details to this feature:

[x] Email validation on form submission
[x] A thank you template the appears after successful submission then self-closes after four seconds
[x] Google Analytics event tracking

ribner commented 8 years ago

I added a file called Segment.js in admithub telescope theme. This file asks for a meteor settings variable that can be stored in our settings.json file alongside the shared auth key.

yourcelf commented 8 years ago

This breaks Linux (including heroku) because of inconsistency between the case of filenames and the names in package.js -- check lightbox.styl.

OS X's filesystem is case insensitive, so it works there, but it will fail on any case sensitive filesystem. (I'd fixes this previously but the commits here undo my fix).

pcorey commented 8 years ago

I pushed a fix before deploying to stage.