search

AdmitHub / admithub-common

Common styles, templates, and library functions for AdmitHub apps
0 stars 2 forks source link

Ceeb code lookup is overly permissive #15

Open yourcelf opened 8 years ago

yourcelf commented 8 years ago

We're blindly trusting the results of CeebCodes.findCeebCode for setting a ceeb code in students' CollegeProfile. But this can be wildly off, especially if wacky data is entered:

> CeebCodes.findCeebCode("CA", "Nonsense", "Yer Mum")
{ _id: { _str: '55d66bb16f3170fa06285996' },
  ceeb: '053861',
  city: 'Woodland',
  state: 'CA',
  highschool: 'Pioneer High School-Woodland CA',
  score: 1.7000000000000002 }

It might be worth setting a minimum match score for results that is a bit higher, or in some other way trying to limit this.

AndrewMagliozzi commented 8 years ago

Hey Charlie, for sure. Colleges at fairs demanded Ceeb codes as a required field. They did not, however, specify accuracy.

We should ideally reprompt if if the fuzzy match is not accurate. "We did not find a match. Please provide the full name of your high school"

This is not urgent, however.