AdmitHub / admithub-common

Common styles, templates, and library functions for AdmitHub apps
0 stars 2 forks source link

AH-96 add holocene-context related fields #217

Closed djrochford closed 5 years ago

djrochford commented 5 years ago

This is in preparation for a NeOlith PR related to AH-96, which restores input-context functionality.

The fields on brandedUserProfile are my idea; however, the fields on the Dialog and Dialog state documents are things that were already referred to in the code, but were missing from the schema. It appears that a feature related to input-contexts was half-finished before we launched NeOliTh; I'm in the process of finishing it as part of AH-96.

A lot of changes are just my auto-formatter; the field I added to brandedUserProfiles is holoceneContext. The fields I added to dialog and dialogState are both called contexts.

Note that I'm using the before.update hook on the BrandedUserProfile document to time-stamp changes to my new field; I generalised the code in that hook a little bit while I was at it.