search

AdmitHub / admithub-telescope-theme

2 stars 2 forks source link

Fix Pending Posts on Prod #39

Closed AndrewMagliozzi closed 9 years ago

AndrewMagliozzi commented 9 years ago

Currently all posts still appear in pending posts...

not sure why

pcorey commented 9 years ago

It looks like the pending/approved process is working in Prod.

An issue I found is that when you click "Load More" at the bottom of pending, it actually redirects you to "https://college.admithub.com/top/20" instead of "https://college.admithub.com/pending/20". This made it look like all of the approved posts were actually in the Pending section.

I fixed the bug that was causing this and pushed the change to production. It looks to be working correctly now.

Let me know if there's something I'm missing here...

AndrewMagliozzi commented 9 years ago

I'm still seeing a ton of already approved questions in "pending" on prod...

pcorey commented 9 years ago

If you give me a few links to posts that are showing up as Pending, but should be approved I can dig into what's going on.

AndrewMagliozzi commented 9 years ago

Hey Pete, did you see the links I sent to you on Slack?

On Mon, Aug 10, 2015 at 11:53 AM, Pete Corey notifications@github.com wrote:

If you give me a few links to posts that are showing up as Pending, but should be approved I can dig into what's going on.

— Reply to this email directly or view it on GitHub https://github.com/AdmitHub/admithub-telescope-theme/issues/39#issuecomment-129503850 .

pcorey commented 9 years ago

Yeah,

I haven't had a change to dig into them yet.

For posterity: https://college.admithub.com/posts/peYwHtM4HKdgWKA9m/p/will-a-great-personal-statement-help-me-if-i-have-a-2-5-2-8-gpa-for-uc-admissions- https://college.admithub.com/posts/PEk4nfMYvvC4tvqFH/p/will-a-great-personal-statement-help-me-if--i-have-a-2-5-2-8-gpa-

pcorey commented 9 years ago

We removed all pending posts. Re-open this if more dupes pop up.