AdmitHub / admithub-telescope-theme

2 stars 2 forks source link

Navbar overflows when notifications menu is shown beween 872px and 747px. #9

Closed yourcelf closed 9 years ago

yourcelf commented 9 years ago

Between 910px and 747px with the new wider search box. We've got to figure out a way to reclaim 160px when in that range.

screenshot from 2014-11-05 15 21 32

yourcelf commented 9 years ago

Mostly there now -- still pathalogical for a few pixels between medium and large:

screenshot from 2014-11-06 23 50 30

This is Chromium at 895px, but is similar in Firefox. The worst performance is for admins who have the extra "Admin" menu; but even without that, we still get the "Ask" button wrapping to the next line if the notification menu is present.

yourcelf commented 9 years ago

Also consider long-named people: screenshot from 2014-11-06 23 57 04

We could set a max-width and overflow ellipsis or something on the name field...

jordantomax commented 9 years ago

I think bundling the user with notifications would be smart, something like this:

notification-with-user

Is that reasonable @yourcelf ?

AndrewMagliozzi commented 9 years ago

Agreed!

On Sat, Nov 8, 2014 at 7:01 PM, Jordan Cooperman notifications@github.com wrote:

I think bundling the user with notifications would be smart, something like this:

[image: notification-with-user] https://cloud.githubusercontent.com/assets/37018/4965981/7c3ec944-67a3-11e4-8189-38336afd9aac.jpg

— Reply to this email directly or view it on GitHub https://github.com/AdmitHub/admithub-telescope-theme/issues/9#issuecomment-62284182 .

jordantomax commented 9 years ago

Ok, not perfect since it's difficult to get the notifications into the user menu, but I've done a little styling on the notifications as per last commit. @yourcelf let us know when it's on stage