search

AdmitHub / meteor-buildpack-horse

Heroku buildpack for Meteor v1.0+. The horse one.
MIT License
642 stars 590 forks source link

core.js needs to be added when deploying with Meteor 1.6 #184

Closed hems closed 6 years ago

hems commented 6 years ago
Summary

Using meteor version 1.6, deploying to heroku the first time i accessed the website my chrome console asked me to meteor npm install core-js

Contents of .meteor/release
METEOR@1.6
Buildpack version
https://github.com/AdmitHub/meteor-buildpack-horse.git
Deployment target

heroku

tosbourn commented 6 years ago

@hems were you deploying a brand new application and using 1.6, or did you upgrade your application that was already deploying fine to 1.6 when it broke?

When deploying an updated version I get the following error;

Error: The babel-runtime npm package could not be found in your node_modules  
directory. Please run the following command to install it: 

meteor npm install --save babel-runtime

I've tried doing that to no avail – I'm wondering if it is the same on a fresh project.

hems commented 6 years ago

it was a new app i believe, anyway after installing core-js everything worked great. it's just weird that it only "complained" when running on my staging environment

myt588 commented 6 years ago

same problem here meteor@1.6 once core.js is installed everything seems to be working fine

hems commented 6 years ago

I can confirm this actually happened on an Ubuntu box I ran a new 1.6 meteor project, without using this build pack ( just manually installed it there )

So it seems it's actually related to running 1.6 on Linux and not about building it with this build pack!

persac commented 6 years ago

For completeness, my experience:

  1. Local (OSX) update from 1.5.4 to 1.6: no problems
  2. Deploy to Heroku using buildpack-horse: blank page, Chrome console asks me to install npm core-js
  3. Locally run meteor npm install --save core-js
  4. Deploy again: app now runs fine on Heroku

Sorry, this post doesn’t really add anything to the thread.

hems commented 6 years ago

@persac exactly, this happens even if you run the application on a linux server yourself, without using heroku or the buildpack so i reckon it's not related to this repository!

assadvirgo commented 6 years ago

On both Ubuntu and OSX facing the similar issue installed core-js bable-runtime but nothing helped.