search

AdmitHub / meteor-buildpack-horse

Heroku buildpack for Meteor v1.0+. The horse one.
MIT License
641 stars 586 forks source link

Fix clear cache flag checking #190

Closed ErikGartner closed 6 years ago

ErikGartner commented 6 years ago

The flag BUILDPACK_CLEAR_CACHE was checked in an improper way causing problem when the flag exists but is empty.

The new checking method is also more consistent with other flags in the compile file.

chdsbd commented 6 years ago

Looks great. Do you mind updating these other two places with your new method?

https://github.com/AdmitHub/meteor-buildpack-horse/blob/055446a0036685c6269e5f09f31a089d2aadcb56/bin/compile#L181

https://github.com/AdmitHub/meteor-buildpack-horse/blob/055446a0036685c6269e5f09f31a089d2aadcb56/bin/compile#L30

ErikGartner commented 6 years ago

Done :)

chdsbd commented 6 years ago

Thanks for the PR!