search

AdnanHodzic / auto-cpufreq

Automatic CPU speed & power optimizer for Linux
https://foolcontrol.org/?p=4603
GNU Lesser General Public License v3.0
5.32k stars 259 forks source link

Fix #715, #713, #634 issues #716

Closed Angel-Karasu closed 4 weeks ago

Angel-Karasu commented 1 month ago

Closes #715 : Pipe can cause problem for python 3.9 or earlier Closes #713 : Using getoutput instead read to bypass symbolic link problem Closes #634 : Compatible with many arguments

AdnanHodzic commented 4 weeks ago

@Angel-Karasu since description is not very descriptive, does this PR close/fix all of the mentioned issues? As by looking at code that's the impression I'm getting but wanted to confirm.

As in that case I'd suggest something like Closes: #YX. After PR is merged, then I would suggest you update all 3 issues with message like: "PR #716 is merged which should fix the issue, if problem persists, please feel free to re-open it" or something along those lines.

Angel-Karasu commented 4 weeks ago

I've improved the description I'll follow your suggestions after the PR merge

AdnanHodzic commented 4 weeks ago

Thank you for your contribution, you will be credited for your work as part of future release.