search

Adobe-CEP / Samples

Code samples for CEP extensions
MIT License
984 stars 552 forks source link

PProPanel shows a non-working and misleading way to enable Node.js #92

Closed matangover closed 6 years ago

matangover commented 6 years ago

PProPanel is misleading. It contains the --enable-nodejs directive in the manifest but that directive does nothing, because:

  1. CEFCommandLine is in the wrong place. It's under <DispatchInfo> instead of under <Resources>.
  2. <ExtensionManifest Version="4.0">, instead of "5.0" or higher (but not "8.0" because then your extension is not loaded, of course...).

If we copy the sample to create our own panel, we expect Node.js to work since --enable-nodejs is defined. However, it doesn't work. This can be verified by debugging in Chrome (cep_node is undefined) and also by enabling verbose logging, opening ~/Library/Logs/CSXS/CEP8-PPRO.log and seeing that CEFCommandLine is not displayed for PProPanel.

Please add documentation of minimum Version and CEFCommandLine location in manifest. I just wasted a whole day on this. The sample here is correct.

Related: #74

Topic

This is an issue regarding:

Versions

matangover commented 6 years ago

@bbb999 why closed?

bbb999 commented 6 years ago

Because I just made the requested changes...?

matangover commented 6 years ago

Ahh sorry where did you make them?

bbb999 commented 6 years ago

Apparently, only in my mind. ;) Pushing, again...

matangover commented 6 years ago

Thanks for the prompt fix!! I suggest you apply the same fix to PProPanel-vscode.

bbb999 commented 6 years ago

Apply to where, exactly?

matangover commented 6 years ago

https://github.com/Adobe-CEP/Samples/blob/master/TypeScript/PProPanel-vscode/CSXS/manifest.xml