search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
453 stars 600 forks source link

Drag and Drop to `Image` Component Dialog Non-functional After Installing #1393

Closed gerardvh closed 6 years ago

gerardvh commented 6 years ago

Required Information

Expected Behavior

Dragging an image from the filesystem onto the Image component dialog drop zone should add the image to the dialog for submission.

Actual Behavior

Dragging an image from the filesystem onto the Image component dialog drop zone opens the image to be viewed in the browser (default browser behavior).

Steps to Reproduce

  1. Create fresh AEM author instance at v6.3.0 (with sample We.Retail content)
    • Note: also confirmed to occur with CFP1 and SP1
  2. Navigate to http://localhost:4502/editor.html/content/we-retail/us/en.html
  3. Add Image component to parsys at bottom of page
  4. Open dialog for Image component and drag image onto the drop zone
  5. Observe expected behavior.
  6. Install ACS Commons Content package through crx/packmgr
  7. Reload page at http://localhost:4502/editor.html/content/we-retail/us/en.html
  8. Repeat step 4
  9. Observe unexpected behavior
  10. Completely remove and delete ACS Commons Content package through crx/packmgr
  11. Observe unexpected behavior still occurs

Additional Note

At the possibility of this being an issue with AEM itself, I also have created a DayCare ticket for them to investigate the issue on their end.

gerardvh commented 6 years ago

Further clarification:

Here's the expected ending behavior for a drag and drop action to a dialog box drop zone: expected_behavior

And here is the actual behavior when dropping an image after installing acs-aem-commons-content: actual_behavior

Versions

Also, I have confirmed this issue is similar when testing on the latest version of Chrome, as well as Safari 11.1.1 on Mac OS 10.12.6, and for AEM versions 6.3.0, 6.3.0.1, 6.3.2.0.

davidjgonzalez commented 6 years ago

@gerardvh are there any JavaScript errors in the browser's Console between loading the page in the page editor and D&D'ing into the Image component?

gerardvh commented 6 years ago

Hi @davidjgonzalez, thanks for the response.

I just checked again while watching the Console in Chrome, and the only warning or message is something like this: Resource interpreted as Document but transferred with MIME type image/png: "file:///Users/gerardvh/Desktop/test%20png%20images/L1030152%20(1).png".

This message appears to be pretty standard and also comes up when dragging and dropping an image on the browser from a different site.

There are no other errors.

gerardvh commented 6 years ago

Just another note here regarding steps 9 and 10 on the initial issue.

It appears that rebuilding the JSP's and clientlibs after uninstalling the content package fixes the issue again. But there is still an issue while the ACS Commons Content package is installed.

Also, DayCare was able to also reproduce this issue on their end and they have created an internal Jira issue to track it, just in case there is a problem with their code. However, they believe the issue is actually being caused by something in the ACS Commons Content package and were not able to offer any sort of work-around.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.